Skip to content

ENH: Add compression to stata exporters #34013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2020
Merged

ENH: Add compression to stata exporters #34013

merged 1 commit into from
May 12, 2020

Conversation

bashtage
Copy link
Contributor

@bashtage bashtage commented May 5, 2020 •
edited
Loading

Add standard compression optons to stata exporters

closes #26599

@bashtage bashtage force-pushed the stata-compression branch from 3553924 to f1c87bf Compare May 5, 2020 22:17
@simonjayhawkins
Copy link
Member

Thanks @bashtage for the PR. if you merge master the np-dev ci failure should be resolved. Also a couple of lint failures.

@simonjayhawkins simonjayhawkins added Enhancement IO Stata read_stata, to_stata labels May 8, 2020
simonjayhawkins
simonjayhawkins reviewed May 8, 2020
View reviewed changes
pandas/core/frame.py Outdated
'.gz', '.bz2', '.zip', or 'xz', respectively, and no compression
otherwise.

.. versionadded:: 1.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intentional? is it ok to target 1.1? maybe still a couple of weeks away.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure of the timing; I've moved to 1.1.0.

@bashtage bashtage force-pushed the stata-compression branch 7 times, most recently from efa6ec5 to 6456672 Compare May 11, 2020 11:16
@bashtage bashtage requested a review from simonjayhawkins May 11, 2020 12:15
@jreback jreback added this to the 1.1 milestone May 11, 2020
jreback
jreback approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, very nice. if anyone else wants to have a look. @pandas-dev/pandas-core

@jreback
Copy link
Contributor

jreback commented May 12, 2020

can you merge master

@bashtage bashtage force-pushed the stata-compression branch from 6456672 to 2c886b5 Compare May 12, 2020 15:26
@jreback jreback merged commit 5724728 into pandas-dev:master May 12, 2020
@jreback
Copy link
Contributor

jreback commented May 12, 2020

thanks @bashtage

@MaxGhenis MaxGhenis mentioned this pull request May 12, 2020
Open
@bashtage bashtage deleted the stata-compression branch July 28, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@simonjayhawkins simonjayhawkins Awaiting requested review from simonjayhawkins

Assignees
No one assigned
Labels
Enhancement IO Stata read_stata, to_stata
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Compression keyword for Stata and others?
3 participants
@bashtage @simonjayhawkins @jreback